Skip to content
Snippets Groups Projects

Allow different time reference and polarizations in MBTransient

Merged Colm Talbot requested to merge fixes-to-mbtransient into master
All threads resolved!

This is a follow up to !972 (merged) that adds generalizations to add missing functionality:

  • non-standard polarizations to be passed
  • non-standard time references to be used properly

@soichiro.morisaki are you able to confirm that this doesn't cause any issue with the algorithm. I ran the example with these features being used an it gave a sensible looking result.

Merge request reports

Pipeline #285086 passed

Pipeline passed for ee92dbbf on fixes-to-mbtransient

Test coverage 0.00% (0.00%) from 1 job
Approved by

Merged by Colm TalbotColm Talbot 3 years ago (Oct 22, 2021 5:18pm UTC)

Pipeline #310725 failed

Pipeline failed for d51d5194 on master

Test coverage 0.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot mentioned in merge request !1027 (merged)

    mentioned in merge request !1027 (merged)

  • Colm Talbot added 1 commit

    added 1 commit

    • ee92dbbf - Fix time offset and delta f end for non-geocent reference time

    Compare with previous version

  • Soichiro Morisaki approved this merge request

    approved this merge request

  • @colm.talbot Thank you so much for fixing them! I think it doesn't cause any issue except for one related to the time reference. I approve this, though I don't think my approval is meaningful here.

  • Sylvia Biscoveanu approved this merge request

    approved this merge request

  • Colm Talbot resolved all threads

    resolved all threads

  • Colm Talbot approved this merge request

    approved this merge request

  • Colm Talbot unapproved this merge request

    unapproved this merge request

  • Colm Talbot approved this merge request

    approved this merge request

  • Colm Talbot mentioned in commit d51d5194

    mentioned in commit d51d5194

  • merged

  • Colm Talbot mentioned in merge request !1040 (merged)

    mentioned in merge request !1040 (merged)

  • Colm Talbot changed milestone to %1.1.5

    changed milestone to %1.1.5

  • Please register or sign in to reply
    Loading