Skip to content
Snippets Groups Projects

Fix detector orientations

Merged Stephen Green requested to merge stephen.green/bilby:fix-L1-orientation into master
All threads resolved!

This addresses #606 (closed) as well as other detector orientations.

Summary of changes:

  • Add arm tilts for L1
  • Add arm tilts for K1
  • Swap arms for GEO600
  • Create a new test to compare plus polarizations against LAL

After fixing L1 orientation (as originally planned) the newly-created test failed on K1 and GEO600. It turns out that the K1 configuration did not include tilts either (resulting in a much larger error than L1, since K1 is more inclined), and that GEO600 configuration had swapped the X and Y arms entirely, resulting in O(1) deviations compared to LAL.

Merge request reports

Checking pipeline status.

Approved by

Merged by Moritz HuebnerMoritz Huebner 3 years ago (Nov 1, 2021 3:36am UTC)

Pipeline #311126 passed

Pipeline passed for 3dda2bbb on master

Test coverage 0.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stephen Green resolved all threads

    resolved all threads

  • Stephen Green added 1 commit

    added 1 commit

    • faea5e66 - Add all 6 polarizations to test

    Compare with previous version

  • Matthew Pitkin resolved all threads

    resolved all threads

  • Matthew Pitkin approved this merge request

    approved this merge request

  • Stephen Green approved this merge request

    approved this merge request

  • Colm Talbot approved this merge request

    approved this merge request

  • added Detector label

  • Moritz Huebner changed milestone to %1.2.0

    changed milestone to %1.2.0

  • Moritz Huebner approved this merge request

    approved this merge request

  • Moritz Huebner mentioned in commit 3dda2bbb

    mentioned in commit 3dda2bbb

  • Colm Talbot changed milestone to %1.1.5

    changed milestone to %1.1.5

  • Please register or sign in to reply
    Loading