Skip to content

Implement time marginalization into ROQ likelihood

Soichiro Morisaki requested to merge soichiro/bilby:time_marg_roq into master

This MR implements time marginalization into bilby.gw.likelihood.ROQGravitationalWaveTransient.

  • This uses simple matrix operations to compute d_inner_h at each time sample.
  • A user can specify delta_tc used for marginalization. The default value is the value from self._get_time_resolution().
  • It calculates the sidereal time at self._beam_pattern_reference_time = (tcmin + tcmax) / 2. to avoid the systematic errors reported in #608.
  • It passes the p-p test for low- and aligned-spin BNS signals, whose median SNR is ~25 (See the figure below).

p-p

Edited by Soichiro Morisaki

Merge request reports