Skip to content
Snippets Groups Projects

Update for nessai v0.4.0

Merged Michael Williams requested to merge michael.williams/bilby:update-nessai-v0.4.0 into master

I recently released version 0.4.0 of nessai and added some new keyword arguments. This means the bilby interface for nessai needs updating.

I've opted to overhaul how the default kwargs are defined for nessai. This is to simplify things so I don't have to main two sets of up-to-date defaults and should mean less code changes on the bilby side of things in the future.

Instead of defining an exhaustive list within bilby in default_kwargs the code now inspects the modules in nessai to define the set of all possible kwargs and uses their values as the defaults. These values are then updated with any values we want to override in bilby, for example the output or with reviewed settings if nessai were to be reviewed.

To-do

  • Check unit tests for nessai
Edited by Michael Williams

Merge request reports

Pipeline #320781 passed

Pipeline passed for bd57eab0 on michael.williams:update-nessai-v0.4.0

Approved by

Merged by Colm TalbotColm Talbot 3 years ago (Nov 29, 2021 6:12pm UTC)

Merge details

  • Changes merged into master with 5adbd1f2 (commits were squashed).
  • Did not delete the source branch.

Pipeline #322782 failed

Pipeline failed for 5adbd1f2 on master

Test coverage 0.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading