Bilby cython geometry

Closes #576 (closed)

This is similar to !1053 (merged) with the difference being that the cython code is included in the bilby source.

As you can see, this involves some changes to how the setup runs. This now requires cython to install from source, but shouldn't require users to have cython installed to use the package. Many users will have it as some samplers require it and it is available in igwn.

Additionally, there are some differences to how installing locally works. If the packages is installed as pip install . things will no longer work as expected if running in the base directory of the repository, pip install -e . will work in that case though.

I haven't tested that the packaging will work as expected so I will manually check that if we go with this option before we upload to pypi.

added Feature-request label

added 25 commits

• 4d3dbf37...cbcf32a0 - 24 commits from branch master
• 89fae82b - Merge branch 'master' into 'bilby-cython-geometry'

Compare with previous version

added 12 commits

• 89fae82b...e04d1190 - 11 commits from branch master
• fb8ed3e0 - Merge remote-tracking branch 'origin/master' into bilby-cython-geometry

Compare with previous version

added 7 commits

• fb8ed3e0...d909cd31 - 6 commits from branch master
• 805d63a4 - Merge branch 'master' into 'bilby-cython-geometry'

Compare with previous version

changed milestone to %1.2.0

approved this merge request

We discussed this on a dev call today and decided to close this in favour of !1053 (merged) (adding the cython code to a new repository/package).

closed