Skip to content

Fix type requirements for lalsimulation

Colm Talbot requested to merge fix-lalsim-types into master

I noticed errors like the trace below when specifying the pn_amplitude_order and an integer reference frequency. I also added specification of float type for tidal deformabilities.

Traceback (most recent call last):
  File "/home/colm.talbot/.conda/envs/online-dev/bin/bilby_pipe_plot", line 33, in <module>
    sys.exit(load_entry_point('bilby-pipe', 'console_scripts', 'bilby_pipe_plot')())
  File "/home/colm.talbot/modules/bilby_pipe/bilby_pipe/plot.py", line 191, in main
    plot_waveform()
  File "/home/colm.talbot/modules/bilby_pipe/bilby_pipe/plot.py", line 168, in plot_waveform
    result.plot_waveform_posterior(
  File "/home/colm.talbot/modules/bilby/bilby/gw/result.py", line 259, in plot_waveform_posterior
    self.plot_interferometer_waveform_posterior(
  File "/home/colm.talbot/modules/bilby/bilby/core/utils/plotting.py", line 65, in wrapper_decorator
    return func(*args, **kwargs)
  File "/home/colm.talbot/modules/bilby/bilby/gw/result.py", line 480, in plot_interferometer_waveform_posterior
    wf_pols = waveform_generator.frequency_domain_strain(params)
  File "/home/colm.talbot/modules/bilby/bilby/gw/waveform_generator.py", line 130, in frequency_domain_strain
    return self._calculate_strain(model=self.frequency_domain_source_model,
  File "/home/colm.talbot/modules/bilby/bilby/gw/waveform_generator.py", line 175, in _calculate_strain
    model_strain = self._strain_from_model(model_data_points, model)
  File "/home/colm.talbot/modules/bilby/bilby/gw/waveform_generator.py", line 188, in _strain_from_model
    return model(model_data_points, **self.parameters)
  File "/home/colm.talbot/modules/bilby/bilby/gw/source.py", line 89, in lal_binary_black_hole
    return _base_lal_cbc_fd_waveform(
  File "/home/colm.talbot/modules/bilby/bilby/gw/source.py", line 311, in _base_lal_cbc_fd_waveform
    start_frequency = lalsim.SimInspiralfLow2fStart(
TypeError: in method 'SimInspiralfLow2fStart', argument 1 of type 'REAL8'

Merge request reports