BUGFIX: Fix marginalized parameter reconstruction with pool (!1132) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 25 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Colm Talbot requested to merge bugfix-marginalized-pool-reconstruction into master 2 years ago

@cjhaster pointed out that the marginalized parameter reconstruction with a pool was broken in a recent commit as a generator is returned instead of tuple. This MR explicitly casts the returned quantity to a tuple.

Activity

Colm Talbot added Bug Conversion labels 2 years ago

added Bug Conversion labels
Colm Talbot changed milestone to %1.2.0 2 years ago

changed milestone to %1.2.0
Carl-Johan Haster @cjhaster · 2 years ago

Maintainer

I'll just add here that after I've implemented the fix contained in this MR, the issue of the broken pool is resolved and the parameter reconstruction can proceed as it should.
Carl-Johan Haster approved this merge request 2 years ago

approved this merge request
Colm Talbot added 7 commits 2 years ago
added 7 commits

330e7ef4...602eaa64 - 6 commits from branch master

ffc49978 - Merge remote-tracking branch 'origin/master' into bugfix-marginalized-pool-reconstruction

Compare with previous version
Michael Williams approved this merge request 2 years ago

approved this merge request
Matthew David Pitkin approved this merge request 2 years ago

approved this merge request
Colm Talbot merged 2 years ago

merged
Colm Talbot mentioned in commit fb9ee616 2 years ago

mentioned in commit fb9ee616

Please register or sign in to reply