CI FIX: Make sure setuptools_scm is installed for sdist building (!1147) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 25 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Colm Talbot requested to merge fix-pip-deploy into master 2 years ago

There was a little snafu with the pypi upload for the new tag after switching to setuptool_scm. Due to a known issue with setuptools the code was tagged as v0.0.0.

The fix is to make sure setuptools_scm is installed in that job. I've run a test that the dist will build properly. I'll revert some of the CI changes when that passes.

(I manually pushed the tag with the correct label to pypi.)

Edited 2 years ago by Colm Talbot

Approved by

Activity

Colm Talbot changed milestone to %1.3.0 2 years ago

changed milestone to %1.3.0
Colm Talbot added Infrastructure label 2 years ago

added Infrastructure label
Colm Talbot changed the description 2 years ago

changed the description
Colm Talbot added 1 commit 2 years ago
added 1 commit

7fd75dec - Move the dist building bag to only on tags

Compare with previous version
Gregory Ashton approved this merge request 2 years ago

approved this merge request
Michael Williams @michael.williams · 2 years ago

Maintainer

Sorry I missed this. I'm used to using python -m build and didn't think to check this works automatically with setup.py build.
Michael Williams approved this merge request 2 years ago

approved this merge request
Sylvia Biscoveanu mentioned in commit 0c06ce2b 2 years ago

mentioned in commit 0c06ce2b
Sylvia Biscoveanu merged 2 years ago

merged

Please register or sign in to reply