Skip to content
Snippets Groups Projects

Optimizations to multiband weights

Merged Optimizations to multiband weights
soichiro/bilby:dump_multiband_coeffs into master
All threads resolved!
Merged Soichiro Morisaki requested to merge soichiro/bilby:dump_multiband_coeffs into master
All threads resolved!

This MR makes a few optimizations on computing multiband weights in MBGravitationalWaveTransient.

  • This MR speeds up weights computations by optimizing the computations of window function at evenly-spaced frequency points. For a 1.4Msun-1.4Msun BNS signal observed from 5Hz, this optimization reduces its run time from minutes to seconds.
  • This MR adds save_weights and setup_multibanding_from_weights methods, which can be used to save/load multiband weights as done for ROQ. This can save the cost of precomputing weights for the second execution. Type checks are updated so that the likelihood can properly load numbers from a .hdf5 weights file. Unit tests are also added for testing this in/out.
  • Add minimum_frequency, maximum_frequency, and number_of_bands properties as they are frequency used for setting up multiband weights.

I have verified that the multiband weights produced by the new codes are the same as those from the previous codes in this notebook.

Edited by Soichiro Morisaki

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Colm TalbotColm Talbot 2 years ago (Jan 30, 2023 10:31pm UTC)

Pipeline #493997 passed

Stage: initial
Stage: test
Stage: docs
Stage: deploy

Pipeline passed for 5d2ec5e2 on master

Test coverage 66.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
  • Soichiro Morisaki added 11 commits

    added 11 commits

    • c2984ca4...d5580325 - 8 commits from branch lscsoft:master
    • 97938094 - bilby/gw/likelihood/multiband.py: optimize computations of window function
    • 1f26fc7d - Enable MBGravitationalWaveTransient to save/load multiband weights
    • c631a510 - bilby/gw/likelihood/multiband.py: add number_of_bands property

    Compare with previous version

    Toggle commit list
  • Soichiro Morisaki added 1 commit

    added 1 commit

    • a6218091 - bilby/gw/likelihood/multiband.py: utilize hdf5 in/out functions implemented in core/utils

    Compare with previous version

  • Colm Talbot approved this merge request

    approved this merge request

  • Colm Talbot changed milestone to %1.4.2

    changed milestone to %1.4.2

  • Soichiro Morisaki resolved all threads

    resolved all threads

  • Gregory Ashton approved this merge request

    approved this merge request

  • Colm Talbot merged

    merged

  • Colm Talbot mentioned in commit 5d2ec5e2

    mentioned in commit 5d2ec5e2

    • Please register or sign in to reply