Skip to content
Snippets Groups Projects

MAINT: clarify the data consistency test

Merged MAINT: clarify the data consistency test
data-consistency-test-clarity into master
All threads resolved!
Merged Colm Talbot requested to merge data-consistency-test-clarity into master
All threads resolved!

@michael.williams pointed out that the data consistency test is pretty unclear. It looks like there's an argument we could be using instead of the combined statement.

I also added a test for the case where one result has a nan log noise evidence but the others don't as that is a case that should fail.

Merge request reports

Pipeline #472963 passed

Stage: initial
Stage: test
Stage: docs
Stage: deploy

Pipeline passed for 75c7a244 on data-consistency-test-clarity

Test coverage 64.00% (0.00%) from 1 job
Approved by
Michael Williams Matthew David Pitkin

Merged by Colm TalbotColm Talbot 2 years ago (Nov 2, 2022 8:48pm UTC)

Merge details

  • Changes merged into master with 14499abb (commits were squashed).
  • Deleted the source branch.

Pipeline #473318 passed with warnings

Stage: initial
Stage: test
Stage: docs
Stage: deploy

Pipeline passed with warnings for 14499abb on master

Test coverage 64.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot resolved all threads

    resolved all threads

  • Colm Talbot added 1 commit

    added 1 commit

    Compare with previous version

  • Colm Talbot added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Williams approved this merge request

    approved this merge request

  • Matthew David Pitkin approved this merge request

    approved this merge request

  • Colm Talbot changed milestone to %1.4.0

    changed milestone to %1.4.0

  • Colm Talbot mentioned in commit 14499abb

    mentioned in commit 14499abb

  • Colm Talbot merged

    merged

    • Please register or sign in to reply