MAINT: hack around numpy deprecated float/int/bool

Updated: 1/3/23

Numpy 1.24 finally pulled the trigger on removing the np.float deprecation. We have three options at this stage:

• remove support for ptemcee/nestle. I would strongly rather not do this as I actively use both samplers and I know at least some others do also.
• get an updated release of the samplers. I know that people have discussed this and attempting to reach out to the original author to allow this.
• hack around the problem and hope nothing else breaks later. This is what is done here.

As an extremely ugly workaround for this, I propose that we manually set the now missing ptemcee.sampler.np.float and nestle. This is equivalent to just setting np.float, but makes it more clear why we are doing it. If there is ever a new release of either we should just remove this clause.

I also had to make a few changes to the HealPixPrior. Specifically, the self.distance_dist was returning a one-element array rather than a float. I simplified the code in that section a little and removed the distance_dist attribute.

added <10 lines Bug Sampling labels

added 1 commit

• 1470e580 - MAINT: formatting fix

Compare with previous version

It looks like the same issue is impacting nestle and the same fix will work.

There's also a bug in our healpix prior that is causing the other failures. It looks like the new version of numpy is more picky about being given one-element arrays rather than numbers.

added 1 commit

• 036cd5df - MAINT: update nestle and healpix prior for deprecations

Compare with previous version

changed title from MAINT: hack around ptemcee/numpy bug to MAINT: hack around numpy deprecated float/int/bool

changed the description

added 10-100 lines label

removed 10-100 lines label

added 1 commit

• 7ca325d8 - MAINT: add np.int to nestle

Compare with previous version

added 1 commit

• e24b18ee - MAINT: fix nestle numpy int catch

Compare with previous version

added 1 commit

• 8e95a954 - FORMAT: remove unused import

Compare with previous version

changed milestone to %1.4.2

approved this merge request

Is the distance_dist attribute that was removed not needed or useful? Is there a loss of functionality with this change?

resolved all threads

approved this merge request

mentioned in commit b84af262

merged