BUGFIX: Fix SNR calculation with relative binning (!1198) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Sylvia Biscoveanu requested to merge sylvia.biscoveanu/bilby:fix_snr_relbin into master 2 years ago

Currently the SNR calculation in post-processing fails for the relative binning likelihood unless fiducial is added as a delta function prior at 0. This is actually unnecessary and was caused by evaluating the waveform on the wrong sample dictionary that did not include the fiducial parameter.

Approval is optional

Activity

Sylvia Biscoveanu added Bug Conversion labels 2 years ago

added Bug Conversion labels
Sylvia Biscoveanu added 1 commit 2 years ago
added 1 commit

b96ccfa0 - Remove extra line from example

Compare with previous version
Colm Talbot approved this merge request 2 years ago

approved this merge request
Colm Talbot added <10 lines label 2 years ago

added <10 lines label
Colm Talbot changed title from Fix SNR calculation with relative binning to BUGFIX: Fix SNR calculation with relative binning 2 years ago

changed title from Fix SNR calculation with relative binning to BUGFIX: Fix SNR calculation with relative binning
Colm Talbot changed milestone to %1.4.2 2 years ago

changed milestone to %1.4.2
Gregory Ashton approved this merge request 2 years ago

approved this merge request
Colm Talbot merged 2 years ago

merged
Colm Talbot mentioned in commit b078e588 2 years ago

mentioned in commit b078e588

Please register or sign in to reply