Interface for gwsignal (new waveform interface)

• Adds a new frequency-domain source model: gwsignal_binary_black_hole, highly mimicking the behavior of lal_binary_black_hole, allowing to interface gwsignal (the new waveform interface https://git.ligo.org/waveforms/new-waveforms-interface).

added 1 commit

• b62fd783 - Fixing gwsignal import to work with inclusion of gwsignal in lalsimulation

Compare with previous version

added 2 commits

• 821f5076 - Only import gwsignal if its there
• 1895a4cb - Merge branch 'import_guards' into 'gwsignal'

Compare with previous version

Thanks for getting this moving @hector.estelles. I added a couple of comments.

Do you have an idea of the timeline on which gwsignal will be available within lalsimulation?

Hi Colm,

the review readiness presentation of gwsignal was last week. I think the target is to finish the review within a month, but the gwsignal developers can provide a better estimate.

added 21 commits

• 1895a4cb...63c71cb7 - 9 commits from branch lscsoft:master
• c97708e5 - Adding source class for GWsignal waveform models
• 276bcde2 - adding postadiabatic flag
• 4849da8c - fixing bug
• 61a16516 - Update bilby/gw/source.py
• 5e9ca0ce - adapting to changes in gwsignal
• 0d8b913b - Making bilby agnostic to gwsignal approximants
• 9d966509 - Modifying EDOM error in gwsignal_binary_black_hole
• 59abffb9 - Changing import path for gwsignal_get_waveform_generator
• 5d39dbf7 - solving problem when passing mode_array to gwsignal
• f809aa79 - fixing ModeArray None issue for LAL approximants and deleting some extra parameters from extra_args
• e64b7062 - Deleting unneeded import from utils.py
• c0cdd764 - Fixing gwsignal import to work with inclusion of gwsignal in lalsimulation

Compare with previous version

added 1 commit

• 43fab50a - fixing import issue

Compare with previous version

added 2 commits

• 55fe231b - Make code style happy
• 31bf3e9b - Merge branch 'import_guards' into 'gwsignal'

Compare with previous version

@hector.estelles and @serguei.ossokine commenting here as well as the chat. If this is ready for review can you remove the draft status. My overall comment is that this would significantly benefit from CI testing. I'll try to have a deeper look soon.

changed milestone to %2.1.0

added >100 lines label

added 69 commits

• 31bf3e9b...2140bcea - 55 commits from branch lscsoft:master
• ff36e0cf - Adding source class for GWsignal waveform models
• f2106e2b - adding postadiabatic flag
• 7dddac3f - fixing bug
• d9d130f4 - Update bilby/gw/source.py
• 2ec1b27b - adapting to changes in gwsignal
• 1d2c3799 - Making bilby agnostic to gwsignal approximants
• d838bb99 - Modifying EDOM error in gwsignal_binary_black_hole
• 7d0a1efe - Changing import path for gwsignal_get_waveform_generator
• 484edb1c - solving problem when passing mode_array to gwsignal
• 522cfc58 - fixing ModeArray None issue for LAL approximants and deleting some extra parameters from extra_args
• 78cc7732 - Deleting unneeded import from utils.py
• 3f791dc5 - Fixing gwsignal import to work with inclusion of gwsignal in lalsimulation
• bc166f91 - fixing import issue
• 4f60a2f2 - Make code style happy

Compare with previous version

marked this merge request as ready

Hi @hector.estelles please can you add unit tests based on https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw/source_test.py#L11-L95?

Once the new release of lalsimulation is available, I'll trigger a rebuild of the testing containers so that this will work.

added 1 commit

• f627cf0d - Adding unit test for gwsignal with SEOBNRv5PHM

Compare with previous version

added 1 commit

• 5ec76b41 - adapting test names

Compare with previous version

changed milestone to %Future

To coordinate a plan for this, since it will not be ready for 2.1.0, can we target "2.2.0"? If there are no major updates to the sampler, then the review would then consist only of ensuring that review bilby (i.e. 2.1.x) can successfully use the new waveform interface (2.2.0)

added 34 commits

• 5ec76b41...62efe7e0 - 18 commits from branch lscsoft:master
• 068a2997 - Adding source class for GWsignal waveform models
• 4cb140d7 - adding postadiabatic flag
• 90874f4d - fixing bug
• 30d639c8 - Update bilby/gw/source.py
• 74e3984a - adapting to changes in gwsignal
• 2118af94 - Making bilby agnostic to gwsignal approximants
• 80afa5e1 - Modifying EDOM error in gwsignal_binary_black_hole
• 5685433f - Changing import path for gwsignal_get_waveform_generator
• 3c3e048a - solving problem when passing mode_array to gwsignal
• eb533420 - fixing ModeArray None issue for LAL approximants and deleting some extra parameters from extra_args
• 63551075 - Deleting unneeded import from utils.py
• 8f86f796 - Fixing gwsignal import to work with inclusion of gwsignal in lalsimulation
• fe461427 - fixing import issue
• 7d3a912b - Make code style happy
• 3376d551 - Adding unit test for gwsignal with SEOBNRv5PHM
• f4d00383 - adapting test names

Compare with previous version