Skip to content
Snippets Groups Projects

BUGFIX: fix act-walk caching

Merged Colm Talbot requested to merge fix-act-walk-caching into master

@serguei.ossokine pointed out that the act-walk is not working with parallelization, the reason for the issue is that the object gets pickled at each call to the sampler and so instance-level attributes aren't being preserved properly.

To fix this, I made the _cache a class-level attribute. I also made sure that the cache is wiped at the beginning of sampling in case people run multiple analyses with this method using a single script/session in a jupyter notebook.

I removed the use of premade instances of the walking methods as it wasn't achieving anything.

EDIT: there was an equivalent problem with the rwalk method that had a similar solution

Edited by Colm Talbot

Merge request reports

Pipeline #502257 passed

Pipeline passed for f6017840 on fix-act-walk-caching

Test coverage 67.00% from 1 job
Approved by

Merged by Colm TalbotColm Talbot 2 years ago (Mar 13, 2023 10:24pm UTC)

Merge details

  • Changes merged into master with e019b5a2.
  • Deleted the source branch.

Pipeline #505078 passed

Pipeline passed for e019b5a2 on master

Test coverage 67.00% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading