Address memory issue with compute SNRs

assigned to @gregory.ashton

This makes a lot of sense. We should also include this for the other likelihood classes.

added 10-100 lines Likelihood labels

changed milestone to %2.0.1

resolved all threads

added 1 commit

• cbc6bf5a - Avoid calculating arrays if not needed and add documentation

Compare with previous version

@colm.talbot I updated with the suggestion. If you would like to implement for other likelihood classes, can you? I'm not so familiar with the interface there so you can probably address it without me screwing things up. But, I'd like to see this in a release shortly as it makes processing difficult for the BNS.

added 1 commit

• cd5c1f77 - Add return_array for roq method

Compare with previous version

I'm not sure if you saw this, but I put some suggested changes in !1228 (merged).

added 2 commits

• 98c344e4 - DEV: add return_array option to other likelihood classes
• 55a52125 - Merge remote-tracking branch 'origin/return-array-other-likelihoods' into...

Compare with previous version

Thanks @colm.talbot

Looked over the MR, and looks fine! There could be docstrings added for the relative likelihood, but I can start a separate MR for that if required.

mentioned in merge request !1226 (closed)

mentioned in merge request !1231 (merged)

The tests are failing with fixes included in !1229 (merged).

approved this merge request

resolved all threads

merged

mentioned in commit 8268a0c6

picked the changes into the branch release/2.0.x with commit 8575d920

mentioned in commit 8575d920