Skip to content
Snippets Groups Projects

Simplify wg redundant code

Merged Moritz Huebner requested to merge Simplify_wg_redundant_code into master
All threads resolved!

There is a lot of duplicate code in frequency_domain_strain and time_domain_strain that I eliminated. This also reduces the size of the methods and updates the test suite for the module. It now also has an identity expression as a default for parameter_conversion.

Edited by Moritz Huebner

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moritz Huebner added 71 commits

    added 71 commits

    • d9a8f1e8...fec78ee9 - 69 commits from branch master
    • 68f9195f - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code
    • d906d871 - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code

    Compare with previous version

  • Colm Talbot resolved all discussions

    resolved all discussions

  • Moritz Huebner resolved all discussions

    resolved all discussions

  • Moritz Huebner added 1 commit

    added 1 commit

    • 80e79aad - Made accessing the utils module via the full path

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    • e8a52861 - Fixed an error in utils function calls

    Compare with previous version

  • Colm Talbot approved this merge request

    approved this merge request

  • Moritz Huebner added 3 commits

    added 3 commits

    • e8a52861...04be9369 - 2 commits from branch master
    • 91336055 - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    • 0e1cc4e5 - Now imports just utils and and not the entire project

    Compare with previous version

  • @colm.talbot can you approve again? I just changed the import to be:

    from tupak.core import utils instead of import tupak and changed the function calls accordingly

  • Colm Talbot approved this merge request

    approved this merge request

  • merged

  • Colm Talbot mentioned in commit 502cc09c

    mentioned in commit 502cc09c

  • Please register or sign in to reply
    Loading