Simplify wg redundant code
All threads resolved!
All threads resolved!
There is a lot of duplicate code in frequency_domain_strain
and time_domain_strain
that I eliminated. This also reduces the size of the methods and updates the test suite for the module. It now also has an identity expression as a default for parameter_conversion
.
Edited by Moritz Huebner
Merge request reports
Activity
added 9 commits
- 572745cf - Simplified some more
- a75c90b4 - Did some debugging to get tests working again
- a7db459e - Some minor simplifications
- 90652314 - Reordered private methods for readability
- 5d1ec4de - Updated a docstring
- 331d153b - Changed the default argument for parameter_conversion to be a lambda expression…
- 694a971f - Reverted to the last functioning version
- 375814aa - re-Reverted
- 2d7e3ae5 - Made some overall improvements and threw out some shoddy stuff that should not…
Toggle commit listassigned to @colm.talbot
- Resolved by Colm Talbot
added 71 commits
-
d9a8f1e8...fec78ee9 - 69 commits from branch
master
- 68f9195f - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code
- d906d871 - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code
-
d9a8f1e8...fec78ee9 - 69 commits from branch
added 1 commit
- 80e79aad - Made accessing the utils module via the full path
added 3 commits
-
e8a52861...04be9369 - 2 commits from branch
master
- 91336055 - Merge remote-tracking branch 'origin/master' into Simplify_wg_redundant_code
-
e8a52861...04be9369 - 2 commits from branch
added 1 commit
- 0e1cc4e5 - Now imports just utils and and not the entire project
@colm.talbot can you approve again? I just changed the import to be:
from tupak.core import utils
instead ofimport tupak
and changed the function calls accordinglymentioned in commit 502cc09c
Please register or sign in to reply