bilby/gw/likelihood.py: make phase of d_inner_h consistent with that of the other likelihoods

d_inner_h for multiband was np.conj(data).dot(template) but for the other likelihoods np.conj(template).dot(data). This MR takes the complex conjugate of the multiband d_inner_h to make them all consistent. Since likelihood depends on its real part (absolute part for phase marginalization), this difference does not bias parameter recovery results during sampling. However, phase resampled from phase marginalization will be mapped into its negative. This fixes #678 (closed).

mentioned in issue #678 (closed)

I have confirmed that with this fix we no longer see flat distribution of matched-filter SNRs pointed out by #678 (closed). See https://ligo.gravity.cf.ac.uk/~soichiro.morisaki/multiband-likelihood-review/pe_mdc/128s_hawk/21_comparison_phasefix/html/Comparison_SNR_all.html.

added <10 lines Bug labels

changed milestone to %2.1.1

added Likelihood label

approved this merge request

approved this merge request

merged

mentioned in commit cbf9e6d1

picked the changes into the branch release/2.1.x with commit ac77a611

mentioned in commit ac77a611

mentioned in merge request !1249 (closed)

mentioned in merge request !1255 (merged)