Adding outdir support for ultranest's mpi functionality
Similar to pymultinest, do not use temporary outdir when the sampler is running with mpi
Merge request reports
Activity
added <10 lines label
added 10-100 lines label
removed <10 lines label
added <10 lines label
Hi @tsun-ho.pang the author list test is failing. Please add yourself to https://git.ligo.org/lscsoft/bilby/-/blob/master/AUTHORS.md.
- Automatically resolved by Tsun-Ho Pang
Hi @tsun-ho.pang thanks for contributing this! I think it would be neater to have this added to the super class https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/base_sampler.py#L903-L907, that way we can avoid any repetition.
Would you mind moving this to that file and removing it from the
pymultinest
class?added 1 commit
- 6d3c5a22 - Moving MPI check for temp outdir to base_sampler
changed milestone to %2.2.0
mentioned in commit 9c1dda6c
Hi @tsun-ho.pang it looks like your change to the author list is failing on master (https://git.ligo.org/lscsoft/bilby/-/jobs/2889773). I'm not sure why it worked in the MR. Do you mind if I push a fix to make it read Peter Tsun-Ho Pang to resolve this?