Skip to content
Snippets Groups Projects

Adding outdir support for ultranest's mpi functionality

Merged Tsun-Ho Pang requested to merge support_mpi_for_ultranest into master
All threads resolved!

Similar to pymultinest, do not use temporary outdir when the sampler is running with mpi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @tsun-ho.pang thanks for contributing this! I think it would be neater to have this added to the super class https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/base_sampler.py#L903-L907, that way we can avoid any repetition.

    Would you mind moving this to that file and removing it from the pymultinest class?

  • Tsun-Ho Pang resolved all threads

    resolved all threads

  • Tsun-Ho Pang added 1 commit

    added 1 commit

    • 6d3c5a22 - Moving MPI check for temp outdir to base_sampler

    Compare with previous version

  • Colm Talbot approved this merge request

    approved this merge request

  • Matthew David Pitkin approved this merge request

    approved this merge request

  • Colm Talbot changed milestone to %2.2.0

    changed milestone to %2.2.0

  • Colm Talbot mentioned in commit 9c1dda6c

    mentioned in commit 9c1dda6c

  • merged

  • Hi @tsun-ho.pang it looks like your change to the author list is failing on master (https://git.ligo.org/lscsoft/bilby/-/jobs/2889773). I'm not sure why it worked in the MR. Do you mind if I push a fix to make it read Peter Tsun-Ho Pang to resolve this?

  • Yea sure, that's perfectly fine. Thanks a lot!!

  • Please register or sign in to reply
    Loading