TEST: fix numpy array testing (!1303) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Colm Talbot requested to merge waveform-generator-test into master 1 year ago

All threads resolved!

It looks like a numpy change in how array comparisons are done has broken some tests, this MR should increase the reliability of these tests. This will fail one test because of !1294 (merged). This doesn't actually impact the codebase, just the tests.

Activity

Gregory Ashton approved this merge request 1 year ago

approved this merge request
Michael Williams @michael.williams started a thread on an old version of the diff 1 year ago

Resolved 1 year ago by Colm Talbot
Last reply by Colm Talbot 1 year ago

Michael Williams @michael.williams · 1 year ago

Maintainer

One question but otherwise LGTM

Michael Williams changed milestone to 1 year ago

changed milestone to %2.2.1

Michael Williams added label 1 year ago

added Testing label

Colm Talbot resolved all threads 1 year ago

resolved all threads

Colm Talbot resolved all threads 1 year ago

resolved all threads

Colm Talbot added 1 commit 1 year ago

added 1 commit

96882745 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

Colm Talbot added 3 commits 1 year ago

added 3 commits

317c382c - 1 commit from branch master
204a219a - TEST: fix numpy array testing
4982c96e - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

Michael Williams approved this merge request 1 year ago

approved this merge request

Colm Talbot merged 1 year ago

merged

Please register or sign in to reply