Skip to content

Added flag to skip constraint normalization during sampling. This avoids...

This MR is a proposed solution to the mattermost discussion regarding intractably long initialization times with BilbyMCMC and BilbyPTMCMC when sampling in EoS model parameters and applying the standard EoS constraints to the standard parameter priors.

The long initialization times are a result of the method by which the constraint normalization factor is computed: samples are drawn from the prior after which constraints are applied. This process is repeated many times at which point the ratio of samples that passed the constraint requirements to the total number of samples are drawn is computed and used as the constraint normalization factor. The issue with this approach for EoS sampling is that EoS constraints require numerical integration and have an exceptionally low acceptance rate for samples drawn from the prior. As a result, the initialization process takes on the order of days and currently cannot be checkpointed. During sampling this is an unnecessary computation as the normalization factor, which appears in the numerator and denominator of Bayes' theorem, cancels in the MH ratio.

Therefore, this MR implements a flag that can be activated to disable computation of the constraint normalization factor, reenabling EoS parameter estimation when using the BilbyMCMC and BilbyPTMCMC samplers.

Merge request reports