Skip to content

Convert LALDict to python dictionary before saving

Aditya Vijaykumar requested to merge aditya.vijaykumar/bilby:dev-lal-dict-issue into master

Fixes #693.

Uses lalsimulation.gwsignal.core.utils.from_lal_dict to convert a LALDict to a python dictionary before saving.

I have a few concerns which I was not sure how to tackle:

  1. The new logic has the downside that it is the only part of code in core/result.py that depends on a function in gw. The other option is to define an equivalent _get_save_data_dictionary inside the CompactBinaryCoalescenceResult class.
  2. Right now this imports the relevant function from LALSimulation, but we could have just copied over the relevant code into bilby (since LALSuite is under GNU GPL).

Merge request reports