MAINT: Separate adding SNRs per IFO to a sample into a new function

Moves code snippet which adds IFO snrs to a sample into a separate function within the Likelihood. Thus different likelihoods may define this differently if they have different SNRs which must be computed.

added 1 commit

• 627295c0 - MAINT: Pre-commit cleanup

Compare with previous version

@colm.talbot this implements what we were discussing to increase compatibility for alternate likelihoods implemented by plugins.

added 1 commit

• 2fe0f226 - MAINT: Import Interferometer in base.py

Compare with previous version

added 39 commits

• 2fe0f226...103a5127 - 35 commits from branch lscsoft:master
• d9be9a4c - MAINT: Separate adding SNRs per IFO to a sample into a new function
• 7045c030 - MAINT: Move add_interferometer_snrs_to_sample to likelihood for better compatibility
• 24ee81a1 - MAINT: Pre-commit cleanup
• a746dc97 - MAINT: Import Interferometer in base.py

Compare with previous version

Thanks @rhiannon.udall! It looks like this is essentially extracting the relevant elements of the _ComputedSNR to a dictionary. Maybe we could add a method to that class definition to do this, and then we could call that directly in conversion.py.

added 1 commit

• 172f7c1a - ENH: Try alternate option for structuring reading snrs from _CalculatedSNRs

Compare with previous version

added 1 commit

• 77d9da81 - ENH: Cleanup previous implementation and correct final dataframe update

Compare with previous version

added 11 commits

• efa3a72c - 1 earlier commit
• 83ae74a0 - ENH: Allow results to be read from PathLike objects
• 19fa2ffb - BUG: using the soft_init sampler kwargs with dynesty caused an AttributeError
• 68544d89 - DOC: Adding a citation guide for bilby
• 6d37a348 - BUG: Resolve "Linestyle bug in bilby.core.result.plot_multiple"
• 07b68d96 - BUGFIX: Resolve "Missing import in bilby.gw.detector.load_data_from_cache_file"
• 4f6be1f0 - ENH: Add support for sampler plugins
• b4a7742f - DOC: some clarifications in dynesty guide
• 88b3d995 - DOC: Resolve "Typo in the documentation"
• b5e585a6 - BUG: fix dynesty crash when autocorrelation length estimate and/or nact is very long
• bc7e9667 - BUG: Make `snrs_as_sample` a property not a method

Compare with previous version

added 17 commits

• bc7e9667...1c2cbeb6 - 10 commits from branch lscsoft:master
• f13db088 - MAINT: Separate adding SNRs per IFO to a sample into a new function
• ca799cb9 - MAINT: Move add_interferometer_snrs_to_sample to likelihood for better compatibility
• e77d4fea - MAINT: Pre-commit cleanup
• 08917a69 - MAINT: Import Interferometer in base.py
• 9648e258 - ENH: Try alternate option for structuring reading snrs from _CalculatedSNRs
• 87833447 - ENH: Cleanup previous implementation and correct final dataframe update
• e19f1477 - BUG: Make `snrs_as_sample` a property not a method

Compare with previous version

resolved all threads

approved this merge request

approved this merge request

approved this merge request

added 9 commits

• e19f1477...01575b9f - 2 commits from branch lscsoft:master
• 20553f67 - MAINT: Separate adding SNRs per IFO to a sample into a new function
• 74f72c2a - MAINT: Move add_interferometer_snrs_to_sample to likelihood for better compatibility
• 165af18d - MAINT: Pre-commit cleanup
• 5454e19b - MAINT: Import Interferometer in base.py
• a8716555 - ENH: Try alternate option for structuring reading snrs from _CalculatedSNRs
• a6168fcc - ENH: Cleanup previous implementation and correct final dataframe update
• 1074eecc - BUG: Make `snrs_as_sample` a property not a method

Compare with previous version

merged

changed milestone to %2.3.0