Skip to content
Snippets Groups Projects

BUG: fix dynesty crash when autocorrelation length estimate and/or nact is very long

Closes #668 (closed) In the dynesty sampler loop, return the current live points when the number of "found" points is smaller than the estimated autocorrelation length (times the thinning factor). This prevents a divisionbyzero error since in that case, thinning is not applicable anymore.

Would it be worth adding a logger message that recommends lowering the "nact" value?

Merge request reports

Merge request pipeline #608142 skipped

Merge request pipeline skipped for 08f12b4b

Approval is optional

Merged by Colm TalbotColm Talbot 1 year ago (Mar 15, 2024 10:25pm UTC)

Merge details

  • Changes merged into master with 1c2cbeb6 (commits were squashed).
  • Deleted the source branch.

Pipeline #610993 failed

Pipeline failed for 1c2cbeb6 on master

Test coverage 71.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading