Skip to content
Snippets Groups Projects

Add an exponential distribution likelihood function

Merged Matthew Pitkin requested to merge matthew-pitkin/bilby:exponential_likelihood into master
All threads resolved!

I've added an exponential distribution likelihood function.

Refs #157 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moritz Huebner
  • Matthew Pitkin added 1 commit

    added 1 commit

    • ac3846c2 - likelihood.py: Fix doc string for exponential likelihood

    Compare with previous version

  • Moritz Huebner resolved all discussions

    resolved all discussions

  • Moritz Huebner approved this merge request

    approved this merge request

  • @matthew-pitkin I approved this MR. I think you should be able to press merge now on the top of this page.

  • @moritz.huebner thanks. I'm still not set as a tupak developer, so can't do the merge. Would you be able to add me as a project member?

  • mentioned in issue #157 (closed)

  • @matthew-pitkin I've just added you as a developer. Let us know if there're any issues.

  • @paul-lasky thanks. As a developer am I able to merge PRs? There merge button for this PR hasn't become available to me, but I'm more than happy for someone else to merge.

  • Matthew Pitkin resolved all discussions

    resolved all discussions

  • Matthew Pitkin added 2 commits

    added 2 commits

    • 55a7c442 - Add exponential likelihood to the documentation
    • 9346532b - likelihood_tests.py: add tests for exponential likelihood

    Compare with previous version

  • Matthew Pitkin resolved all discussions

    resolved all discussions

  • Matthew Pitkin added 1 commit

    added 1 commit

    • 7a236c62 - likelihood_tests.py: minor tidy up of exponential likelihood tests

    Compare with previous version

  • I've now also added testing of the exponential likelihood into the likelihood_tests.py script. So, it's even more ready for merging now.

  • It looks like there are conflicts with this MR and https://git.ligo.org/Monash/tupak/merge_requests/147, I suspect this is related to the poisson likelihood that was just merged. @matthew-pitkin can you have a look into this, otherwise, I agree this is ready to merge?

  • Matthew Pitkin resolved all discussions

    resolved all discussions

  • Matthew Pitkin added 66 commits

    added 66 commits

    Compare with previous version

  • @colm.talbot The conflicts should be fixed now.

  • Matthew Pitkin mentioned in merge request !147 (merged)

    mentioned in merge request !147 (merged)

  • Please register or sign in to reply
    Loading