Resolve "add neutron star merger to examples"

I added the lal_binary_neutron_star model with an example file binary_neutron_star_example.py . I had to include an import lal in the file source.py to add tidal deformabilities.

For the bns approximants TaylorF2 and IMRPhenomD_NRTdidal, the parameters tilt_1, phi_12, tilt_2, phi_jl must be set to zero, since these can only handle aligned spins.

Nice!

If this is only valid for aligned spins, you should probably just remove those parameters. We can always add them in in future if the waveforms become available.

resolved all discussions

added 1 commit

• e3a658a4 - simplified bns example and deleted not used spins

Compare with previous version

I have modified the files with @colm.talbot suggestions, but I didn't add a prior file for BNSs. It is apparently more difficult than I expected, especially because I don't quite understand how the funcion test_redundancy works in the class BBHPriorSet of the file tupak/tupak/gw/prior.py

added 1 commit

• 05832335 - added a BNS prior file and modified the BNS example file

Compare with previous version

added 1 commit

• a5e9bff2 - changed BBH to BNS

Compare with previous version

@colm.talbot I've added the BNS prior file as you suggested.

added 1 commit

• 079ad21f - changed BBH to BNS in the description of the prior file

Compare with previous version

added Feature-request label

changed milestone to %0.3

added 1 commit

• 221683f2 - changed bns model docstring

Compare with previous version

added 1 commit

• c64315f3 - make pep happy

Compare with previous version

Can I ask what is happening with this merge request @colm.talbot @francisco.hernandez ? It would be good to have this for a couple of reasons...

added 32 commits

• c64315f3...8d8ddd57 - 24 commits from branch master
• c908a897 - typo
• 810581f0 - rename lambdai -> lambda_i for consistency
• 5768c7e6 - add lambda conversion functions
• c2a3b396 - add default labels for lambda_tilde and delta_lambda
• bac16e06 - add redundancy test for BNS prior
• 1312fdfb - fix conversion tests
• 36e33ced - add extra tidal parameters
• b2f7cf93 - Merge branch 'master' into 176-add-neutron-star-merger-to-examples

Compare with previous version

I've added the ability to sample in lambda_tilde and delta_lambda. Additionally one can now sample in only lambda_tilde or lambda_1 and it assumes a common equation of state.

@colm.talbot when trying to use the binary_neutron_star.prior BNSPriorSet, I am seeing the following error:

bbh_redundancy = BBHPriorSet.test_redundancy(self, key)
TypeError: unbound method test_redundancy() must be called with BBHPriorSet instance as first argument (got BNSPriorSet instance instead)

This was from commit bac16e06 Any advice to fix?

That is not the desired behaviour. I should really have added this to the gw_prior_tests. I think what we need is

bbh_redundancy = BBHPriorSet().test_redundancy(self, key)

@ethan.payne can you try that?

added 1 commit

• 8f952900 - Fixed error with bad call to BBHPriorSet.test_redundancy

Compare with previous version

@colm.talbot Works if:

bbh_redundancy = BBHPriorSet().test_redundancy(key)

Just committed the changes, verified it works