Add flake8 checker
This will cause the CI to fail if people add new code which breaks the flake8 checker.
For an introduction to flake8, see this https://www.caktusgroup.com/blog/2015/08/15/making-clean-code-part-your-build-process/
The rules for the checker are defined in setup.cfg. We can change these in future, either making them more or less stringent.
Related to #181 (closed)
Merge request reports
Activity
This is great, and we should definitely do something like this, I'm just wondering what kind of error messages this generates. I know that some plugins to github give you a breakdown of all the issues with your code rather than just a failing CI. Is that something we'll get here?
I added the repository to my codacy account, https://app.codacy.com/project/talbotcolm/tupak/dashboard, (we got an A!). I think we should consider using this, it will at least provide context for flake8 failing. I believe it is also possible to set up a webhook so the analysis will rerun after every commit.
@colm.talbot please feel free to setup a codacy webhook. Though, eventually we should transition away from personal accounts.
This will simply fail, then if one looks in the logs, you'll see the error message from pep8. Unfortunately, the gitlab-CI doesn't have such a nice interface yet as github. The information is all there, you just have to dig a little (or just run
flake8 .).added 40 commits
-
0094a607...30b153d5 - 38 commits from branch
master - 91648bee - Merge branch 'master' into add-flake8-checker
- d339a288 - More flake8 fixes
-
0094a607...30b153d5 - 38 commits from branch
added 68 commits
-
d339a288...a52d6223 - 66 commits from branch
master - df9b6ed0 - Merge remote-tracking branch 'origin/master' into add-flake8-checker
- 7f9aa69e - Merge remote-tracking branch 'origin/add-flake8-checker' into add-flake8-checker
-
d339a288...a52d6223 - 66 commits from branch
enabled an automatic merge when the pipeline for 990999b0 succeeds
mentioned in commit eda21902
