Resolve "Inconsistent saved `log_likelihood` values"

Closes #182 (closed)

This fixes the ordering of the stored log likelihoods in dynesty and nestle.

This can be demonstrated by appending the following code to https://git.ligo.org/Monash/tupak/blob/master/examples/other_examples/gaussian_example.py

for ii in range(len(result.posterior)):
    if sum(result.posterior.mu.values == result.posterior.mu.values[ii]) > 1:
        break

if np.where(result.posterior.mu.values == result.posterior.mu.values[ii]) ==\
        np.where(result.posterior.log_likelihood.values == result.posterior.log_likelihood.values[ii]):
    print('Working')

This tests that the repeated values of mu in the posterior have equal log_likelihood.

Note that this duplication of posterior samples is due to nestle and dynesty creating as many nested samples as posterior samples.

One can instead downsample to generate the posterior and avoid duplication:

keep = result.nested_samples.weights.values  >\
    np.random.uniform(0, max(result.nested_samples.weights.values), len(result.posterior))
alternate_posterior = result.nested_samples.copy()[keep]

added 3 commits

• d6e765a2 - fix likelihoods stored in dynesty posterior
• 3def4258 - store likelihood in dynesty nested samples
• 8588b700 - store nested samples and fix likelihoods stored in nestle

Compare with previous version

changed the description

assigned to @gregory.ashton

unmarked as a Work In Progress

approved this merge request

added 1 commit

• 4542305d - update changelog

Compare with previous version

approved this merge request

added 32 commits

• 4542305d...f72981b8 - 31 commits from branch master
• 68a46442 - Merge branch 'master' into '182-inconsistent-saved-log_likelihood-values'

Compare with previous version

approved this merge request

approved this merge request

mentioned in commit 69d4d00b

merged

mentioned in issue #200 (closed)