modify imports to reduce tupak references
Merge request reports
Activity
added 3 commits
-
01d4acc9...cd8795f0 - 2 commits from branch
master
- 4d57aeb6 - Merge branch 'master' into remove_tupak_references
-
01d4acc9...cd8795f0 - 2 commits from branch
added 8 commits
-
5fe1d709...cb5235de - 6 commits from branch
master
- a2c8c90c - Merge branch 'master' into remove_tupak_references
- f07b8740 - move around some imports
-
5fe1d709...cb5235de - 6 commits from branch
I'm 100% for cleaning up the imports. I was undecided about absolute vs. relative imports, but am now fine with it.
For the record, this discussion is enlightening https://stackoverflow.com/questions/4209641/absolute-vs-explicit-relative-import-of-python-module in In particular, look at all the answers not just the first. I'll list here the start of the (currently) highest rates answer:
Python relative imports are no longer strongly discouraged, but using absolute_import is strongly suggested in that case.
We are using
absolute_import
in some places, but should it be done for all files? Or just the top-level?mentioned in commit 52aa3a58