Skip to content
Snippets Groups Projects

Fixing some argument bugs in pymc3.py.

Merged Rhys Green requested to merge rhys.green/bilby:master into master
All threads resolved!

The patch !293 (merged) introduced a bug which meant that a step_kwargs argument had to provided if there was a step argument, this patch fixes this by introducing an option if nuts_kwargs/step_kwargs is None:. It also allows the user to specify the draws argument in default_kwargs instead of the init (sorry for two patches!) @matthew-pitkin could you check if these are okay ?

Edited by Rhys Green

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rhys Green marked as a Work In Progress

    marked as a Work In Progress

  • Rhys Green changed title from Fixing some argument bugs in pymc3.py. to WIP : Fixing some argument bugs in pymc3.py.

    changed title from Fixing some argument bugs in pymc3.py. to WIP : Fixing some argument bugs in pymc3.py.

  • Rhys Green changed the description

    changed the description

  • Rhys Green resolved all discussions

    resolved all discussions

  • Rhys Green added 1 commit

    added 1 commit

    • a4467c22 - fixing bug from mr - changing curemthod to curmethod

    Compare with previous version

  • Looks good to me now.

  • Matthew David Pitkin approved this merge request

    approved this merge request

  • Rhys Green unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Rhys Green changed title from WIP : Fixing some argument bugs in pymc3.py. to Fixing some argument bugs in pymc3.py.

    changed title from WIP : Fixing some argument bugs in pymc3.py. to Fixing some argument bugs in pymc3.py.

  • Matthew David Pitkin unapproved this merge request

    unapproved this merge request

  • Here's a patch to this that fixes the initialisation of NUTS 0001-Fixes-to-PyMC3-autoinitialisation-of-NUTS-step-metho.patch

  • Rhys Green added 1 commit

    added 1 commit

    • 1be08c59 - Fixes to PyMC3 autoinitialisation of NUTS step method

    Compare with previous version

  • Matthew David Pitkin approved this merge request

    approved this merge request

  • Gregory Ashton approved this merge request

    approved this merge request

  • Gregory Ashton mentioned in commit 1f724ae8

    mentioned in commit 1f724ae8

  • Please register or sign in to reply
    Loading