detailed tutorial for open data

The tutorial is based on GW150914.py, with the addition of more in depth comments. The code has been adapted to be used for other LOSC events, i.e. all arguments are explicitly specified (e.g. interferometer_names, sample_rate, npoints..), so that they can be easily edited by the user.

Side note: I've used this tutorial to attempt reproducing the same results obtained with lalinference (master) for the posterior distribution of the component masses of GW150914. I've run both codes in the non-spinning case with all the parameters, but the masses, fixed and with approximant IMRPhenomPv2, however the posterior distributions don't agree. I've attached the resulting plot and lalinference config file if people are interested and want to have a look. This is still a work in progress! Comparison_onlyM_noS_m2

config.ini

GW150914.log

This is really great to have, thanks for doing this, I just have a couple of minor nitpicks:

• Typo: Turkey Window -> Tukey Window.
• I'm not sure what the relevance of the reference to the coherence test is here, maybe remove it?
• comoving.txt isn't a prior file, it's just the file we use to generate the uniform in comoving volume prior, you should remove it from this list.
• Typo: durantion and sampling frequency ... -> duration and sampling frequency ...
• The time marginalisation can (as of fairly recently) use a prior if it's passed.
• How would you feel about making the number of live points 500, people using powers of two for the number of live points is one of my pet peeves.
• Maybe add bilby.gw.conversion.generate_all_bbh_parameters as the conversion function? I think it's a sufficiently useful feature to include in a script like this.
• I'm not sure what the default_priors_file does, I think we may have planned to deprecate it and then forgotten. Maybe remove it from this script.

Hi Colm, thank you very much for your feedback! I’ll make these changes ASAP.

added 1 commit

• aa4a8ee9 - Adjusted typos, comments and conversation function after feedback.

Compare with previous version

added 1 commit

• be9288b7 - pep8 error fixed

Compare with previous version

changed milestone to %0.3.5

Hi @virginia.demilio, what sort of timescale do you foresee getting this merged in on? We have a 0.3.5 release scheduled for next week something, but we can push this back a bit further if you need time?

mentioned in merge request !334 (merged)

added 1 commit

• 65e796be - Additional comment on different samplers kwargs.

Compare with previous version

Hi @gregory.ashton, although my work on the comparison between Lalinference and BILBY is not completed yet, I think this tutorial is ready to be merged!

added 1 commit

• 25594910 - Additional comment for different samplers kwargs.

Compare with previous version

unmarked as a Work In Progress

Hi @virginia.demilio, I resolved the WIP status as you said it is good to go. This is looking good and gives a more complete description of working with the open data, thanks for the input.

One thing before I'm happy to approve this: it needs to be moved to the open_data_examples (since it isn't an injection study) and potentially renamed. In that directory, we have GW150914.py which shows how to run on GW150914. Could you rename this GW150914_advanced.py? Or something to that effect?

We might eventually want to have an example which instead shows a triple detector run, but we can leave that for the future.

resolved all discussions

added 1 commit

• 46d6e2a6 - Removing "comparison with Lalinference" reference and changing file name.

Compare with previous version

Hi @gregory.ashton, I've removed the reference to LALInference and changed the file name to GW150914_advanced.py. The file is already located in the example/open_data_examples directory. Thank you very much for your feedback!

Great @virginia.demilio sorry, I must have got confused about where it as located! My bad.

approved this merge request

approved this merge request