Adding PTMCMC sampler
addressing #246 (closed)
Merge request reports
Activity
added 1 commit
- 8aa30731 - changed priors and log likelihood to correct functions, now samples correctly…
@rhys.green this is looking good.
It is currently failing the tests due to some flake8 issues. During the test, we call
$ flake8 .(you can install flakeu with
pip install flake8). This basically checks syntax issues, it is a pain, but it keeps consistency across the project.We'll also need to add the PTMCMC sampler to the docker-image test suite so that it can be tested.
How are you finding the performance, I'm keen to learn more about the custom jump proposals. Let me know if there is anything I can help with.
In terms of timing, I'd like to target this at 0.3.5 release (I'll tag it as such now), which should hopefully be in a few weeks. Let me know if that isn't feasible and we can delay (there is no rush of course!).
changed milestone to %0.3.5
Hi @gregory.ashton I've fixed most of the flake8 problems, there's one which I'm not quite sure how to fix. I'm getting w503 and then to correct this I'm getting w504? Does this matter as it's a warning rather than an error ?
There's a couple of other questions/problems I have. Would you be able to talk quickly after the pe call this evening ?
Edited by Rhys Green-
@rhys.green, are you testing on python3.7? I believe in 3.6 flake8 only one of these caused an error (which is why all the other tests pass).
I've been working on updating our testing to 3.7 and have also been confused by this seeming impasse. My current feeling is to switch off both errors which is what I've done in !327 (diffs)
I'm also happy to chat anytime (when I'm awake, Melbourne time that is!) - just ping me on mattermost.
added 1 commit
- d7ffd885 - fix import error, and added sampler_meta, also fixed flake8 stuff
added 2 commits
- 45ecbb4b - adding changes to other files so that they call ptmcmc
- 61faf33a - Merge branch 'master' of https://git.ligo.org/rhys.green/bilby
@gregory.ashton I'm pretty sure this is ready to be merged now so I'll remove the WIP.
Nice @rhys.green! It's great to see this ready to go. Are you able to add this into the test suite? I'm not sure how difficult it will be to add
PTMCMCto the test images (hopefully @gregory.ashton can comment).It would be nice for it to at least run in this test, https://git.ligo.org/lscsoft/bilby/blob/master/test/sampler_test.py#L384. If you're feeling more ambitious it would be nice to have more testing for this sampler.
@colm.talbot I can add it to the basic test now and then add in some "more ambitious" tests soon !
