Resolve "Consistency of constants between bilby and lalsuite" (!343) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Merged Gregory Ashton requested to merge 224-consistency-of-constants-between-bilby-and-lalsuite into master 6 years ago

1 unresolved thread

Closes #224 (closed)

Edited 6 years ago by Gregory Ashton

Activity

Gregory Ashton changed milestone to %0.3.6 6 years ago

changed milestone to %0.3.6
Gregory Ashton added Bug label 6 years ago

added Bug label
Gregory Ashton added 1 commit 6 years ago
added 1 commit

0337f5ac - Update constants to the astropy constants and add tests

Compare with previous version
Gregory Ashton added 1 commit 6 years ago
added 1 commit

95b139fa - Update the changelog and the likelihood values for tests

Compare with previous version
Gregory Ashton unmarked as a Work In Progress 6 years ago

unmarked as a Work In Progress
Gregory Ashton added 1 commit 6 years ago
added 1 commit

d2c0e0af - More fiddling with tests

Compare with previous version
Gregory Ashton added 1 commit 6 years ago
added 1 commit

786b17f9 - More fixing tests

Compare with previous version
Colm Talbot approved this merge request 6 years ago

approved this merge request
Matthew David Pitkin approved this merge request 6 years ago

approved this merge request
Gregory Ashton merged 6 years ago

merged
Gregory Ashton mentioned in commit ba927837 6 years ago

mentioned in commit ba927837
Sebastian Khan @sebastian-khan started a thread on the diff 6 years ago

bilby/core/utils.py

 logger = logging.getLogger('bilby')
 # Constants
 speed_of_light = 299792458.0  # speed of light in m/s
 parsec = 3.085677581 * 1e16
 solar_mass = 1.98855 * 1e30
 radius_of_earth = 6371 * 1e3  # metres
 # Constants: values taken from astropy v3.0.4
 speed_of_light = 299792458.0  # m/s

Please register or sign in to reply