Skip to content
Snippets Groups Projects

Resolve "Add suggested acknowledgements to the README"

Merged Gregory Ashton requested to merge 253-add-suggested-acknowledgements-to-the-readme into master
All threads resolved!

Closes #253 (closed)

Edited by Gregory Ashton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthew David Pitkin
  • Gregory Ashton added 1 commit

    added 1 commit

    Compare with previous version

  • Gregory Ashton added 1 commit

    added 1 commit

    • 7b426584 - Make section titles just bold

    Compare with previous version

  • Gregory Ashton resolved all discussions

    resolved all discussions

  • @matthew-pitkin it is a good idea to have this in the documentation as well, but in practise I can't figure out how to read in a file content into the README.md. It would be unwise to have two copies of the information as that requires maintaining both, so one needs to have a single citation.txt file which is then sourced for both the documentation and into the README.

    Of course, one could also only put it in the documentation, but I actually think this should be front and centre as a reminder to people, rather than hidden in the docs where few people will look in practise.

  • Moritz Huebner approved this merge request

    approved this merge request

  • Colm Talbot approved this merge request

    approved this merge request

  • Gregory Ashton mentioned in commit 09c54d92

    mentioned in commit 09c54d92

  • @matthew-pitkin , sorry for not waiting to resolve the discussion with you. I've merged it just with the citations in the README. It would be good to add them into the documentation, just need to think about how to do that (and I wanted this merged in) :)

  • @gregory.ashton no problem. I was also having a look at how to include a file in the README and it doesn't look like there's a straightforward solution.

  • Please register or sign in to reply
    Loading