Skip to content
Snippets Groups Projects

Allow time domain approximants

Merged Colm Talbot requested to merge allow_time_domain_approximants into master

Closes #308 (closed)

This changes the lalsimulation function being called and enforces frequency bounds on the waveforms returned.

I noticed there's a lot of duplicate code in the source functions. I'll make a separate issue to rationalise this.

@michael.puerrer can you check this?

UPDATE: I got carried away and made all the lal source functions call a single base function. This is likely a more maintainable solution.

Edited by Colm Talbot

Merge request reports

Pipeline #50574 passed

Pipeline passed for e84fd305 on allow_time_domain_approximants

Test coverage 74.00% (1.00%) from 1 job
Approved by

Merged by Paul LaskyPaul Lasky 6 years ago (Feb 26, 2019 9:38pm UTC)

Merge details

Pipeline #50695 passed

Pipeline passed for 30d9a9a1 on master

Test coverage 74.00% (1.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading