Roq set time step

This hopefully reduces the bias due to insufficient time sampling when constructing the weights.

It looks unbiased for arbitrarily loud heavy BBH.

added 3 commits

• f370a694...502ba66c - 2 commits from branch master
• 626267cf - Merge branch 'master' into 'roq_set_time_step'

Compare with previous version

added 3 commits

• ad64803c - fix path
• e5e03692 - flake fixes
• 0a438900 - Merge branch 'roq_set_time_step' of git.ligo.org:lscsoft/bilby into roq_set_time_step

Compare with previous version

added 1 commit

• 3f3e0e3b - fix ROQ testing

Compare with previous version

approved this merge request

approved this merge request

added 11 commits

• 3f3e0e3b...1db36052 - 10 commits from branch master
• 00431cf0 - Merge branch 'master' into 'roq_set_time_step'

Compare with previous version

added 1 commit

• b103d19c - move test binary closer for roq

Compare with previous version

approved this merge request

changed milestone to %0.4.1

I'm getting the following error when running on IFO data

01:12 bilby_pipe INFO    : Using the ROQ likelihood with roq-folder=/home/cbc/ROQ_data/IMRPhenomPv2/4s/
Traceback (most recent call last):
  File "/home/gregory.ashton/anaconda3/bin/bilby_pipe_analysis", line 11, in <module>
    load_entry_point('bilby-pipe==0.0.3', 'console_scripts', 'bilby_pipe_analysis')()
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby_pipe-0.0.3-py3.6.egg/bilby_pipe/data_analysis.py", line 367, in main
    analysis.run_sampler()
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby_pipe-0.0.3-py3.6.egg/bilby_pipe/data_analysis.py", line 338, in run_sampler
    likelihood=self.likelihood,
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby_pipe-0.0.3-py3.6.egg/bilby_pipe/data_analysis.py", line 306, in likelihood
    distance_marginalization=self.distance_marginalization,
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby-0.4.0-py3.6.egg/bilby/gw/likelihood.py", line 434, in __init__
    self._set_weights()
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby-0.4.0-py3.6.egg/bilby/gw/likelihood.py", line 541, in _set_weights
    self._get_time_resolution(ifo))
  File "/home/gregory.ashton/anaconda3/lib/python3.6/site-packages/bilby-0.4.0-py3.6.egg/bilby/gw/likelihood.py", line 629, in _get_time_resolution
    inj_snr = ifo.meta_data['optimal_SNR']
KeyError: 'optimal_SNR'

It looks like it might be assuming there is an injection?

Ah, I'll set a default...

added 1 commit

• 5ce7843e - add default SNR of 30

Compare with previous version

Thanks for catching this. The default is now SNR=30. That would cover us for 170817.

approved this merge request

approved this merge request

merged

mentioned in commit a9a16d22