Skip to content
Snippets Groups Projects

Periodic boundary update

Merged Periodic boundary update
periodic-boundary-update into master
All threads resolved!
Merged Gregory Ashton requested to merge periodic-boundary-update into master
All threads resolved!

Fixes some minor implementation bugs for dynesty and allows the overwriting of the test_valid_for_rescaling method in order to utilise the periodic boundary conditions.

Builds on !426 (closed)

Merge request reports

Pipeline #57721 passed

Stage: test

Pipeline passed for 5194bf04 on periodic-boundary-update

Test coverage 72.00% (0.00%) from 1 job
Approved by
Colm Talbot Paul Lasky

Merged by Paul LaskyPaul Lasky 6 years ago (Apr 16, 2019 12:56am UTC)

Merge details

  • Changes merged into master with 41468f1c (commits were squashed).
  • Deleted the source branch.

Pipeline #57726 passed

Stage: test
Stage: deploy

Pipeline passed for 41468f1c on master

Test coverage 72.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
    Colm Talbot @colm.talbot ·
    Maintainer

    I've uploaded patches to do that does what I'm trying to describe.

    prior-periodic.patch

    dynesty-periodic.patch

  • Gregory Ashton added 1 commit

    added 1 commit

    Compare with previous version

  • Colm Talbot approved this merge request

    approved this merge request

  • Colm Talbot resolved all discussions

    resolved all discussions

  • Paul Lasky approved this merge request

    approved this merge request

  • Paul Lasky merged

    merged

  • Paul Lasky mentioned in commit 41468f1c

    mentioned in commit 41468f1c

    • Please register or sign in to reply