Skip to content
Snippets Groups Projects

move posterior reconstruction to likelihood classes, this fixes bugs in the reconstruction

Merged Colm Talbot requested to merge fix-distance-reconstruction into master

Closes #358 (closed)

It looks like this was broken by the waveform caching, this has now been fixed by making sure we don't overwrite the cached waveform.

I also took this opportunity to move the functions that reconstruct the likelihood into the likelihood class. This will enable these functions to be used with the ROQ likelihood and is just a bit more logically sensible to me.

This makes it look like a lot of changes, but it's mostly cut and paste.

Merge request reports

Pipeline #57727 passed

Pipeline passed for 14458b0c on fix-distance-reconstruction

Test coverage 72.00% (0.00%) from 1 job
Approved by

Merged by Colm TalbotColm Talbot 6 years ago (Apr 16, 2019 3:35am UTC)

Pipeline #57741 passed

Pipeline passed for a064340d on master

Test coverage 72.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading