Resolve "sampling_frequency and duration should be saved in the CBCResult"

Closes #332 (closed)

added Feature-request Good First Issue labels

added 1 commit

• be5cc6dd - Added start_time, duration, and sampling_frequency to the CBCResult

Compare with previous version

added 1 commit

• 6f49ede7 - Consistently changed ValueErrors to AttributeErrors

Compare with previous version

unmarked as a Work In Progress

changed milestone to %0.4.5

Hey @moritz.huebner should the exceptions you changed be KeyError rather than AttributeError? Don't they come down to keys being missing from the meta data?

Yeah but to the user it looks like they are accessing an attribute. For example, they might do something like this:

import bilby
res = bilby.core.result.read_in_result('res.json')
print(res.sampling_frequency) <-- Raises Error

If res.sampling_frequency is not accessible, I would expect an AttributeError, not a KeyError.

Okay, I just wasn't looking at the whole file, my bad.

approved this merge request

resolved all discussions

added 2 commits

• 8f16be0c - Fixed sampling frequency
• bbeeb58f - Fixed sampling frequency

Compare with previous version

changed milestone to %0.5.0

approved this merge request

approved this merge request

merged

mentioned in commit e2cb1d50