Fixes a bug with the cache when calling frequency_domain_strain and time domain strain after each other (!466) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Moritz Huebner requested to merge series_cache_fix into master 5 years ago

All threads resolved!

Fixes a bug with the cache when calling frequency_domain_strain and time_domain_strain after each other. This is because the second call to the different model will still access the cached result from the first model.

Edited 5 years ago by Moritz Huebner

Approval is optional

Activity

Moritz Huebner changed milestone to %0.5.0 5 years ago

changed milestone to %0.5.0
Moritz Huebner added Bug label 5 years ago

added Bug label
Moritz Huebner marked as a Work In Progress 5 years ago

marked as a Work In Progress
Moritz Huebner added 1 commit 5 years ago
added 1 commit

b8a17695 - Added some tests for caching

Compare with previous version
Moritz Huebner unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
Gregory Ashton approved this merge request 5 years ago

approved this merge request
Colm Talbot @colm.talbot started a thread on the diff 5 years ago

Resolved 5 years ago by Colm Talbot
Last reply by Moritz Huebner 5 years ago

Colm Talbot resolved all discussions 5 years ago

resolved all discussions

Colm Talbot approved this merge request 5 years ago

approved this merge request

Colm Talbot merged 5 years ago

merged

Colm Talbot mentioned in commit 5 years ago

mentioned in commit 90e75e1c

Please register or sign in to reply