allow precessing BNS (!491) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 24 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Colm Talbot requested to merge precessing-bns into master 5 years ago

All threads resolved!

This MR allows the lal_binary_neutron_star source model to be used with precessing spins.

It doesn't put this in by default and doesn't change the API.

I did change the default BNS waveform approximant to be IMRPhenomPv2_NRTidal rather than TaylorF2. The latter is inspiral only, whereas the former includes the standard lalsimulation treatment of tides through the merger. It also works with precessing spins.

Edited 5 years ago by Colm Talbot

Approval is optional

Activity

Colm Talbot added 1 commit 5 years ago
added 1 commit

8debe9a7 - update tests

Compare with previous version
Colm Talbot changed the description 5 years ago

changed the description
Gregory Ashton changed milestone to %0.5.1 5 years ago

changed milestone to %0.5.1
Gregory Ashton approved this merge request 5 years ago

approved this merge request
Moritz Huebner approved this merge request 5 years ago

approved this merge request
Moritz Huebner unapproved this merge request 5 years ago

unapproved this merge request
Moritz Huebner @moritz.huebner started a thread on the diff 5 years ago

Resolved 5 years ago by Moritz Huebner
Last reply by Moritz Huebner 5 years ago

Colm Talbot added 42 commits 5 years ago

added 42 commits

8debe9a7...d678a13e - 40 commits from branch master
9bd3a5e4 - Merge branch 'master' into precessing-bns
2840da7f - Merge branch 'master' into precessing-bns

Compare with previous version

Colm Talbot added 1 commit 5 years ago

added 1 commit

a73d01b6 - update to use Pv2 in BNS example

Compare with previous version

Moritz Huebner resolved all discussions 5 years ago

resolved all discussions

Moritz Huebner approved this merge request 5 years ago

approved this merge request

Gregory Ashton approved this merge request 5 years ago

approved this merge request

Gregory Ashton enabled an automatic merge when the pipeline for succeeds 5 years ago

enabled an automatic merge when the pipeline for a73d01b6 succeeds

Gregory Ashton merged 5 years ago

merged

Gregory Ashton mentioned in commit 5 years ago

mentioned in commit b2f00873

Please register or sign in to reply