minor refactoring of GWT likelihood (!495) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Colm Talbot requested to merge refactor-likelihood into master 5 years ago

This MR moves the likelihood calculation part of the likelihood to different methods for the different marginalisations. It also makes sure the returned quantity is always a float.

The former makes the main log_likelihood_ratio method a little neater and will also allow subclasses to more easily modify how these marginalisations are done.

Approval is optional

Activity

Colm Talbot added Refactoring + 1 deleted label 5 years ago

added Refactoring + 1 deleted label
Gregory Ashton changed milestone to %0.5.1 5 years ago

changed milestone to %0.5.1
Colm Talbot added 1 commit 5 years ago
added 1 commit

98018845 - fix argument name for ROQ

Compare with previous version
Colm Talbot added 1 commit 5 years ago
added 1 commit

f5c64779 - flake fixes

Compare with previous version
Moritz Huebner approved this merge request 5 years ago

approved this merge request
Gregory Ashton approved this merge request 5 years ago

approved this merge request
Gregory Ashton mentioned in commit 9aa84e19 5 years ago

mentioned in commit 9aa84e19
Gregory Ashton merged 5 years ago

merged

Please register or sign in to reply