Prior json format
This MR allows prior dicts (and prior classes) to be read from/written to json.
It's not the prettiest code so style feedback is particularly welcome.
This will allow to store all prior types, relevant to #355 (closed), #192 (closed).
Also, if we make this the default and deprecate the current version, we can remove the eval statement in the prior reading.
Merge request reports
Activity
I like the idea of storing the prior in JSON to solve the issues. But, by deprecate the current version, do you mean our
.priorfiles? If so, I'd be adverse to this as I think they are a really neat way to share priors with minimal writing overhead.If the concern is eval, then there are other ways around it.
Second question. Does this store the prior as a separate file? Or, is it just serisalisabke and then the JSON decoder/encoder writes in in the results?
Currently, it
PriorDictwrites the json to file andPriordoesn't, I can just make both of them return the serialised version and have another option to save thePriorDict. I'll also look at building this into the json result file saving.I agree that keeping the current method would be nice, I'll see if it's possible to improve the parser to avoid using eval. I think there's scope to have both methods though, the json will be much more useful when saving results.
added 10 commits
-
9d1e7e48...9aa84e19 - 8 commits from branch
master - f791497f - Merge branch 'master' into prior_to_json
- e810f3a4 - make test use OrderedDict
-
9d1e7e48...9aa84e19 - 8 commits from branch
changed milestone to %0.5.2
changed milestone to %Future
added 140 commits
-
e810f3a4...567d707b - 139 commits from branch
master - c07620f6 - Merge branch 'master' into prior_to_json
-
e810f3a4...567d707b - 139 commits from branch
added 3 commits
changed milestone to %0.5.5
mentioned in commit c08d62b8
mentioned in issue #468 (closed)