Modify inject signal (!508) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 24 March 2025 starting at approximately 8:30am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Moritz Huebner requested to merge modify_inject_signal into master 5 years ago

All threads resolved!

This restructures some functionality surrounding the inject_signal method.

Added inject_signal_from_waveform_generator and inject_signal_from_waveform_polarizations that are slightly less confusing to use than inject_signal.
Removed if/else statement that checks size of the injected signal. The injection will now just fail if that condition is now not fulfilled. It was already breaking before, but at a different place.
Added explicit tests for these methods.

Edited 5 years ago by Moritz Huebner

Approval is optional

Activity

Moritz Huebner added Refactoring Testing labels 5 years ago

added Refactoring Testing labels
Moritz Huebner added 1 commit 5 years ago
added 1 commit

edd4fe9f - Modified some docstrings

Compare with previous version
Colm Talbot @colm.talbot · 5 years ago

Maintainer

Since this is being reworked, I think it would be worth specifying in some way that this is a frequency domain injection. Maybe as a keyword argument for the inject method. It would be nice to directly support time domain injections in the future. @gregory.ashton has code for that in bilby pipe.
Moritz Huebner added 2 commits 5 years ago
added 2 commits

9cc6e7a9 - Modified a test

f99fa98e - Modified a test

Compare with previous version
Moritz Huebner added 1 commit 5 years ago
added 1 commit

aa4952c1 - Added reference injection test

Compare with previous version
Moritz Huebner added 1 commit 5 years ago
added 1 commit

881fd28f - Made reference injection test only relevant for python3

Compare with previous version
Moritz Huebner added 1 commit 5 years ago
added 1 commit

962170b7 - Made reference injection test only relevant for python3

Compare with previous version
Moritz Huebner added 1 commit 5 years ago
added 1 commit

e9b2eaaf - Added absolute path to reference ifos

Compare with previous version
Moritz Huebner changed the description 5 years ago

changed the description
Moritz Huebner added 1 commit 5 years ago
added 1 commit

1e6acc26 - Added absolute path to reference ifos

Compare with previous version
Moritz Huebner added 1 commit 5 years ago
added 1 commit

36959e2e - Removed integration test for now

Compare with previous version
Moritz Huebner changed the description 5 years ago

changed the description
Moritz Huebner @moritz.huebner · 5 years ago

Author Maintainer

@colm.talbot I think this can always be implemented later on by adding a new keyword argument. I don't see a need to add this keyword argument yet.
Gregory Ashton @gregory.ashton started a thread on an old version of the diff 5 years ago

Automatically resolved 5 years ago by Moritz Huebner
Last reply by Gregory Ashton 5 years ago

Gregory Ashton changed milestone to 5 years ago

changed milestone to %0.5.1

Moritz Huebner resolved all discussions 5 years ago

resolved all discussions

Moritz Huebner added 1 commit 5 years ago

added 1 commit

eb18010a - Changed a docstring

Compare with previous version

Gregory Ashton approved this merge request 5 years ago

approved this merge request

Moritz Huebner added 5 commits 5 years ago

added 5 commits

eb18010a...67914930 - 4 commits from branch master
dc8890b4 - Merge remote-tracking branch 'origin/master' into modify_inject_signal

Compare with previous version

Gregory Ashton approved this merge request 5 years ago

approved this merge request

Colm Talbot approved this merge request 5 years ago

approved this merge request

Gregory Ashton mentioned in commit 5 years ago

mentioned in commit a0d16709

Gregory Ashton merged 5 years ago

merged

Please register or sign in to reply