Modify inject signal

This restructures some functionality surrounding the inject_signal method.

• Added inject_signal_from_waveform_generator and inject_signal_from_waveform_polarizations that are slightly less confusing to use than inject_signal.
• Removed if/else statement that checks size of the injected signal. The injection will now just fail if that condition is now not fulfilled. It was already breaking before, but at a different place.
• Added explicit tests for these methods.

bilby/core/sampler/pymc3.py

@@ -57,8 +57,8 @@ class Pymc3(MCMCSampler):
     default_kwargs = dict(
         draws=500, step=None, init='auto', n_init=200000, start=None, trace=None, chain_idx=0,
         chains=2, cores=1, tune=500, nuts_kwargs=None, step_kwargs=None, progressbar=True,
-        model=None, random_seed=None, live_plot=False, discard_tuned_samples=True,
-        live_plot_kwargs=None, compute_convergence_checks=True)
+        model=None, random_seed=None, discard_tuned_samples=True,
+        compute_convergence_checks=True)
 
     def __init__(self, likelihood, priors, outdir='outdir', label='label',
                  use_ratio=False, plot=False,