Add catch for empty log_evidence_err array
I ran into an issue when trying to use the ResultList
object where all the log evidence errors in my individual runs were infinite so I wasn't able to use the combine()
method. I've just added a catch that if this array is empty, return nan as the new result.log_evidence_err
. I could also see the value in returning the standard deviation of the evidences from the individual runs. What do the rest of you think?
Merge request reports
Activity
changed milestone to %0.5.2
It looks like @sylvia.biscoveanu it is your call if you want to add the std dev :) (or just merge)
added 19 commits
-
68707a93...b383e97b - 17 commits from branch
lscsoft:master
- 52669a34 - add standard deviation of evidence array
- 77906f27 - Merge remote-tracking branch 'lscsoft/master' into combined_result_log_err
-
68707a93...b383e97b - 17 commits from branch
Ok, I decided to keep the
np.nan
because I realized that the standard deviation should probably be thenp.log(np.std(evidences))
notnp.std(log_evidences)
, and I'm worried about things blowing up if I just donp.log(np.std(np.exp(log_evidences)))
, and I don't think I can uselogsumexp
because I have to subtract the mean evidence and then square the difference, and I can't put that whole term in theexp
part... Anyway I think this is ready to be merged now. Pardon my digressionmentioned in commit bfd7510e