Project restructuring

There are still some issues to be resolved on the branch. Some additional suggestions are:

• The hyperparameter likelihood isn't really a GW thing, it probably doesn't belong in the core either.
• The default functionality in prior should be in GW.
• The test_redundancy should be in GW.
• I think references to injection_parameters in core should be changed to true_parameters for generality.
• Result.construct_cbc_derived_parameters should be in gw/conversion, this is something I think I put in the wrong place.

added 1 commit

• 3d232daa - Fixed some of the issues that came up during restructuring

Compare with previous version

added 1 commit

• 1beecc10 - Fixed some of the issues that came up during restructuring

Compare with previous version

added 1 commit

• 616503aa - Fixed some of the issues that came up during restructuring

Compare with previous version

Ok I moved test_redundancy' and create_default_prior` into the gw subpackage

added 1 commit

• 1a3d0046 - Updated to match new package structure

Compare with previous version

added 1 commit

• 22300f9a - Updated to match new package structure

Compare with previous version

added 1 commit

• dbd8f35a - Updated to match new package structure

Compare with previous version

added 1 commit

• 6264d58e - Updated to match new package structure

Compare with previous version

added 1 commit

• 390bb87a - fixed relative parts to work with CI

Compare with previous version

added 1 commit

• 58767ec9 - Fix CI tests

Compare with previous version

This all looks good to me. One final questions: should we have a core directory or just put the files on the top level?

Having a core directory makes it clear why there is a gw.prior and core.prior. I think this argument sells it for me, but any one object before we merge? @colm.talbot @paul-lasky @moritz.huebner ?

mentioned in issue #94 (closed)

I'd like to look through before it's merged just so I understand exactly what's changing, I'll take a look at this (hopefully early) this afternoon.

I like the core directory.

added 2 commits

• de826e4e - Added a test
• 63745698 - Updated some logic in the frequency array setter

Compare with previous version

I'm quite happy with how it is right now, but it is good if somebody reviews the changes before we merge. I think separating it into the core and the gw package makes more sense than having modules at the top level.

I think it's going to be important to define a Priors or PriorSet class. I see this as extending dict to have a fill method and a test_redundancy method. Since I think we currently have gw things being imported in core.

I'm not sure if this should be a barrier to merging.

added 7 commits

• 63745698...cda72bcb - 6 commits from branch master
• 08ad986a - Merge branch 'master' into 'project_restructuring'

Compare with previous version

@colm.talbot with regards to there being gw things in core I'm planning to submit a MR in a bit to fix this. So we can merge and then do that later?

Sure

added 1 commit

• d79fc901 - Removed lalsuite as a requirement for now

Compare with previous version

unmarked as a Work In Progress

merged

mentioned in commit c11f1397