Conversion update

Makes some calls to the conversion module more explicit by returning mutated lists rather than mutating the handed over list. I also extracted a bunch of the conversion logic in convert_to_lal_binary_black_hole_parameters, which allows the user to use conversion logic between component masses, mass ratio, total mass, symmetric mass ratio and the chirp mass.

I added some tests for conversion.py.

Additionally, I changed the implementation of parameters and non_standard_sampling_parameter_keys in GravitationalWaveTransient so that uses a property and setters to refer to it's WaveformGenerator's attributes. I reckon this makes the implementation a bit safer.

test/conversion_tests.py

+from __future__ import division, absolute_import
+import unittest
+import mock
+import tupak
+import numpy as np
+
+
+class TestBasicConversions(unittest.TestCase):
+
+    def setUp(self):
+        self.mass_1 = 20
+        self.mass_2 = 10
+        self.mass_ratio = 0.5
+        self.total_mass = 30
+        self.chirp_mass = 200**0.6 / 30**0.2
+        self.symmetric_mass_ratio = 2/9
+        self.cos_angle = -1
+        self.angle = np.pi
+
+    def tearDown(self):
+        del self.mass_1
+        del self.mass_2
+        del self.mass_ratio
+        del self.total_mass
+        del self.chirp_mass
+        del self.symmetric_mass_ratio
+
+    def test_total_mass_and_mass_ratio_to_component_masses(self):
+        mass_1, mass_2 = tupak.conversion.total_mass_and_mass_ratio_to_component_masses(self.mass_ratio, self.total_mass)
+        self.assertTupleEqual((mass_1, mass_2), (self.mass_1, self.mass_2))
+
+    def test_symmetric_mass_ratio_to_mass_ratio(self):
+        mass_ratio = tupak.conversion.symmetric_mass_ratio_to_mass_ratio(self.symmetric_mass_ratio)
+        self.assertAlmostEqual(self.mass_ratio, mass_ratio)
+
+    def test_chirp_mass_and_total_mass_to_symmetric_mass_ratio(self):
+        symmetric_mass_ratio = tupak.conversion.chirp_mass_and_total_mass_to_symmetric_mass_ratio(self.chirp_mass, self.total_mass)
+        self.assertAlmostEqual(self.symmetric_mass_ratio, symmetric_mass_ratio)
+
+    def test_chirp_mass_and_mass_ratio_to_total_mass(self):
+        total_mass = tupak.conversion.chirp_mass_and_mass_ratio_to_total_mass(self.chirp_mass, self.mass_ratio)
+        self.assertAlmostEqual(self.total_mass, total_mass)
+
+    def test_component_masses_to_chirp_mass(self):
+        chirp_mass = tupak.conversion.component_masses_to_chirp_mass(self.mass_1, self.mass_2)
+        self.assertAlmostEqual(self.chirp_mass, chirp_mass)
+
+    def test_component_masses_to_total_mass(self):
+        total_mass = tupak.conversion.component_masses_to_total_mass(self.mass_1, self.mass_2)
+        self.assertAlmostEqual(self.total_mass, total_mass)
+
+    def test_component_masses_to_symmetric_mass_ratio(self):
+        symmetric_mass_ratio = tupak.conversion.component_masses_to_symmetric_mass_ratio(self.mass_1, self.mass_2)
+        self.assertAlmostEqual(self.symmetric_mass_ratio, symmetric_mass_ratio)
+
+    def test_component_masses_to_mass_ratio(self):
+        mass_ratio = tupak.conversion.component_masses_to_mass_ratio(self.mass_1, self.mass_2)
+        self.assertAlmostEqual(self.mass_ratio, mass_ratio)
+
+    def test_mass_1_and_chirp_mass_to_mass_ratio(self):
+        mass_ratio = tupak.conversion.mass_1_and_chirp_mass_to_mass_ratio(self.mass_1, self.chirp_mass)
+        self.assertAlmostEqual(self.mass_ratio, mass_ratio)
+
+
+class TestConvertToLALBBHParams(unittest.TestCase):
+
+    def setUp(self):
+        self.search_keys = []
+        self.parameters = dict()
+        self.remove = True
+
+    def tearDown(self):
+        del self.search_keys
+        del self.parameters
+        del self.remove
+
+    def test_cos_angle_to_angle_conversion(self):
+        with mock.patch('numpy.arccos') as m:
+            m.return_value = 42
+            self.search_keys.append('cos_tilt_1')
+            self.parameters['cos_tilt_1'] = 1
+            self.parameters, _ = tupak.gw.conversion.convert_to_lal_binary_black_hole_parameters(self.parameters, self.search_keys)
+            self.assertEqual(42, self.parameters['tilt_1'])
+
+    def test_cos_angle_to_angle_conversion_removal(self):
+        with mock.patch('numpy.arccos') as m:
+            m.return_value = 42
+            self.search_keys.append('cos_tilt_1')
+            self.parameters['cos_tilt_1'] = 1
+            self.parameters, _ = tupak.gw.conversion.convert_to_lal_binary_black_hole_parameters(self.parameters, self.search_keys, remove=True)
+            self.assertDictEqual(self.parameters, dict(tilt_1 = 42))
+
+
+if __name__=='__main__':
+    unittest.main()
\ No newline at end of file