GW170817 in open_data_examples

Updating GW170817.py example and creating GW170817.prior file

Can I suggest that we sample in chirp_mass and mass_ratio and possilby lambda_tilde and delta_lamdba_tilde with constraints on mass_1, mass_2, lambda_1, and lambda_2`. I doubt we'll get reasonable results sampling in mass_1 and mass_2 without really slowing down the sampler.

Also, does the prior file work with the line breaks? I will be surprised if it does.

added 1 commit

• 981c8a3b - Apply suggestion to bilby/gw/prior_files/GW170817.prior

Compare with previous version

resolved all threads

added 1 commit

• 9efb16b7 - Sampling in chirp_mass, mass_ratio, lambda_tilde, delta_lambda_tilde

Compare with previous version

changed milestone to %0.5.5

@virginia.demilio is this ready to merge? What is left to be done.

As a warning, this is going to conflict with !573 (merged) I suggest this be merged first of Virginia is ready then I'll merge these changes in there.

added 2 commits

• b816f4c7 - Added parameter_conversion function for bns
• d0cd76bf - Added optional contraint on component masses and lambda1,2

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• a79c9be1 - Fixing minor pep8 issues

Compare with previous version

@gregory.ashton I believe this is now ready to be merged. It runs smoothly on my laptop and I adjusted the prior file as suggested. Cheers :)

added 1 commit

• 8779f08d - Update GW170817.py

Compare with previous version

approved this merge request

approved this merge request

merged

mentioned in commit ee15712a

mentioned in issue #393 (closed)