Skip to content

Give source kwargs

Colm Talbot requested to merge give_source_kwargs into master

This MR demotes some arguments of the source to kwargs, i.e., waveform_approximant, reference_frequency. Defaults are now given for these parameters.

It also allows users to specify a minimum_frequency to use instead of the default (20Hz).

This doesn't stop it from pasting the annoying message saying that it won't be sampled when these are provided. I'm not sure exactly how to do this. But in fill_prior, we could have a check asking if the parameter it's complaining about it a named parameter of the source.

Does this achieve what has been asked for @sylvia.biscoveanu @jan-harms?

@moritz.huebner @gregory.ashton does one of you want to assign yourself to look over the code, it's not a huge change?

Merge request reports

Loading