Fixing bug in dt
Computing dt the following way is inaccurate:
dt = parameters['geocent_time'] + time_shift - self.strain_data.start_time
Indeed the GPS times are number on the order of 1e9 seconds while timeshift varies on the order of 1e-5. Hence if the GPS times are not substracted with one another before the computation is inaccurate.
Merge request reports
Activity
changed milestone to %0.5.6
added Bug label
added 1 commit
- f4d06264 - Fixing bug in dt computation. Shorter comments.
@marc.arene thanks for this. I reran some 170817 jobs with this patch applied, it didn't make any qualitative difference to the outputs so my guess is the error is below the level of standard errors, but this looks great to me.
mentioned in commit 25539b62
Please register or sign in to reply